Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pipeline bootstrapper #739

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Remove pipeline bootstrapper #739

merged 4 commits into from
Feb 1, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jan 26, 2019 •
edited by jlewi
Loading

The bootstrapper is no longer being used as we are now in favor of kubeflow deployment.

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Jan 26, 2019

/assign @neuromage

@neuromage
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Jan 26, 2019

/approve

@IronPan
Copy link
Member Author

IronPan commented Jan 26, 2019

/lgtm

1 similar comment
@neuromage
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 26, 2019

The k8s bot seems to be not working

@IronPan
Copy link
Member Author

IronPan commented Jan 28, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Jan 28, 2019

/test kubeflow-pipeline-build-image

@gyliu513
Copy link
Member

/test kubeflow-pipeline-e2e-test
/lgtm

@neuromage
Copy link
Contributor

/test kubeflow-pipeline-e2e-test

@rileyjbauer
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 6ad2601 into kubeflow:master Feb 1, 2019
ohmystack added a commit to ohmystack/pipelines that referenced this pull request Feb 1, 2019
@ohmystack
Cleanup pipeline bootstrapper
af13477 
As pipeline bootstrapper has been removed in kubeflow#739 , the gitignore file
and deployment guide should be updated as well.
@ohmystack ohmystack mentioned this pull request Feb 1, 2019
Merged
ohmystack added a commit to ohmystack/pipelines that referenced this pull request Feb 8, 2019
@ohmystack
Cleanup pipeline bootstrapper
4458ab5 
As pipeline bootstrapper has been removed in kubeflow#739 , the gitignore file
and deployment guide should be updated as well.
vicaire pushed a commit that referenced this pull request Feb 15, 2019
@ohmystack @vicaire
Cleanup pipeline bootstrapper (#770)
ba70947 
As pipeline bootstrapper has been removed in #739 , the gitignore file
and deployment guide should be updated as well.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Udiknedormin
fix(sdk) sanitize paths in artifact_items. Fixes kubeflow#738 (kubefl…
a968417 
…ow#739)

* sanitize paths in artifact_items

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gyliu513 gyliu513

@rileyjbauer rileyjbauer

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@IronPan @neuromage @Ark-kun @k8s-ci-robot @gyliu513 @rileyjbauer