SDK/Components - Improved error when type checking fails in constructor #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongye-sun
reviewed
Jan 24, 2019
| verify_object_against_type(v, parameter_type) | ||
| try: | ||
| verify_object_against_type(v, parameter_type) | ||
| except Exception as e: |
There was a problem hiding this comment.
nit: is there a more specific exception to catch?
There was a problem hiding this comment.
On one hand, the exception is likely TypeError. On another hand we're re-throwing the error, so we want to wrap all exceptions. Basically, we just add the parameter name information to the exception.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
Ark-kun
deleted the
SDK/Components---Improved-error-when-type-checking-fails-in-constructor
branch
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…ubeflow#732) * Setup a kf-ci-dev namespace for manual sync'ing of Tekton pipelines. * This namespace is intended to allow for testing of changes to the pipelines without having to first check in the changes. Revert "Update Dockerfile.py3 (kubeflow#729)" This commit doesn't build. This reverts commit 0de5733. * Fix the entrypoint in Dockerfile.py3 for kubeflow/testing#684 * Rebuild the test worker image * Fix a bug in kf-ready-task; not properly substituting in KFNAME * Rehydrate * Update
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
… tasks. (kubeflow#732) * chain nested conditions * add missing license * add dependency check to remove unnecessary when expression * minor improvement to check for the exact condition rather than just the condition task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @qimingj @gaoning777 @hongye-sun
This change is