Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create nonexistent directory for roc and confusion_matrix component #720

Merged
merged 4 commits into from
Jan 22, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Jan 22, 2019

fixes: #719


This change is Reviewable

@jinchihe
Copy link
Member Author

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Jan 22, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4267a63 into kubeflow:master Jan 22, 2019
@jinchihe jinchihe deleted the create_dir_for_roc branch January 22, 2019 07:35
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* prctl should support using urls for the flag --repo

* In tekton tasks we can get the URL of the repo directly from
  the git resource so being able to parse OWNER/REPO from a URL
  avoids having to expose an additional parameter.

* Latest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute the component roc and confusion_matrix in TFX sample for local mode
3 participants