-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): Merge v2 code into backend/src/ #7173
Conversation
go-licenses.yaml
Outdated
path: LICENSE | ||
url: https://github.com/census-instrumentation/opencensus-go/blob/v0.22.5/LICENSE | ||
spdxId: Apache-2.0 | ||
# - name: go.opencensus.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bobgy can you share some knowledge about this file? When would we need an override entry as such?
b5778e4
to
22f9caf
Compare
These two tests are failing due to code being moved. I plan to ignore the failures first, and then update the test configs immediately after this PR is merged. |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-integration-v2 |
/test kubeflow-pipelines-v2-go-test |
Error for v2 sample test:
You need to fix relative path in v2/test/requirements.txt. |
License updates LGTM, some changes are not ideal like
is now However, I think the result is good enough considering that we don't need to maintain the override config. |
/test kubeflow-pipelines-v2-go-test |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-samples-v2 |
/test kubeflow-pipelines-integration-v2 |
/test kubeflow-pipelines-samples-v2 |
@chensun: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The tests are quite flaky with some randomly failed executors failed with message: This step is in Error state with this message: Pod failed before main container starts. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* merge v2 code * update go-licenses tool and base licenses files * clean up unused files * fix dockerfiles * fix path to sdk folder * fix path
Description of your changes:
Checklist: