Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Merge v2 code into backend/src/ #7173

Merged
merged 7 commits into from
Jan 25, 2022

Conversation

chensun
Copy link
Member

@chensun chensun commented Jan 19, 2022

Description of your changes:

Checklist:

go-licenses.yaml Outdated
path: LICENSE
url: https://github.com/census-instrumentation/opencensus-go/blob/v0.22.5/LICENSE
spdxId: Apache-2.0
# - name: go.opencensus.io
Copy link
Member Author

@chensun chensun Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bobgy can you share some knowledge about this file? When would we need an override entry as such?

@chensun chensun force-pushed the merge-v2 branch 2 times, most recently from b5778e4 to 22f9caf Compare January 21, 2022 17:03
@chensun chensun changed the title [WIP] merge v2 code chore(backend): Merge v2 code into backend/src/ Jan 21, 2022
@chensun
Copy link
Member Author

chensun commented Jan 21, 2022

@chensun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-v2-go-test 1421952 link true /test kubeflow-pipelines-v2-go-test
kubeflow-pipelines-samples-v2 1421952 link true /test kubeflow-pipelines-samples-v2

These two tests are failing due to code being moved. I plan to ignore the failures first, and then update the test configs immediately after this PR is merged.
/cc @zijianjoy Let me know if you have other thoughts.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@Bobgy
Copy link
Contributor

Bobgy commented Jan 25, 2022

/test kubeflow-pipelines-integration-v2

@Bobgy
Copy link
Contributor

Bobgy commented Jan 25, 2022

/test kubeflow-pipelines-v2-go-test

@Bobgy
Copy link
Contributor

Bobgy commented Jan 25, 2022

Error for v2 sample test:

ERROR: ../../sdk/python is not a valid editable requirement.

You need to fix relative path in v2/test/requirements.txt.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 25, 2022

License updates LGTM, some changes are not ideal like

github.com/gogo/protobuf, https://github.com/gogo/protobuf/blob/v1.3.2/LICENSE, BSD-3-Clause / BSD-2-Clause

is now BSD-3-Clause only.

However, I think the result is good enough considering that we don't need to maintain the override config.

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-v2-go-test
/test kubeflow-pipelines-integration-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-integration-v2

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

/test kubeflow-pipelines-samples-v2

@google-oss-prow
Copy link

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 78ce469 link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member Author

chensun commented Jan 25, 2022

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 78ce469 link true /test kubeflow-pipelines-samples-v2

The tests are quite flaky with some randomly failed executors failed with message: This step is in Error state with this message: Pod failed before main container starts.
Will merge this change as is and look into the test issues afterwards.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun chensun merged commit 1b107eb into kubeflow:master Jan 25, 2022
@chensun chensun deleted the merge-v2 branch January 25, 2022 09:21
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
* merge v2 code

* update go-licenses tool and base licenses files

* clean up unused files

* fix dockerfiles

* fix path to sdk folder

* fix path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants