Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Components - Command line args can only be strings or placeholders #711

Merged
merged 1 commit into from
Jan 25, 2019
Merged

SDK/Components - Command line args can only be strings or placeholders #711

merged 1 commit into from
Jan 25, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 21, 2019 •
edited
Loading

Just replacing PrimitiveTypes with str and removing one test.

This change is Reviewable

@Ark-kun
SDK/Components - Command line args can only be strings or placeholders
8c89256 
Ultimately, command line is an array of strings. Component yaml files should have the arguments as strings instead of Python SDK doing conversion sometimes.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 22, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

/test kubeflow-pipeline-build-image

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8c4f5de into kubeflow:master Jan 25, 2019
@Ark-kun Ark-kun deleted the SDK/Components---Command-line-args-can-only-be-strings-or-placeholders branch April 22, 2019 23:19
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi
Update the worker image in tekton pipelines (kubeflow#711)
3fbde6d 
* Related to GoogleCloudPlatform/kubeflow-distribution#60 previous image was missing
  latest get-credentials code.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@Tomcli
fix broken link for python client gen script (kubeflow#711)
bd3eb29
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Fix(sdk): Tekton copy result step sanitization (kubeflow#711)
9fbccd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@gaoning777 gaoning777

@qimingj qimingj

@hongye-sun hongye-sun

Labels
approved area/sdk/components lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ark-kun @hongye-sun @k8s-ci-robot @gaoning777 @qimingj