-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK/Components - More meaningful error when trying to convert graph component to ContainerOp #710
Conversation
…omponent to ContainerOp
Since there is not going to be a graph component now, why add the if-statement here? Maybe we should add graph component related codes when it is part of the component yaml. |
/retest |
As was decided during the graph component meeting scope, there will be graph components.
To improve the experience of people using the existing compiler that does not support the nested pipelines.
I'm not sure it's good idea. I was asked by Bradley to make my PRs as small as possible. |
/test kubeflow-pipeline-build-image |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Python path should be /srcCache not /src * Related to GoogleCloudPlatform/kubeflow-distribution#65
This change is