Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a link in the side nav to the KF 'usage-reporting' doc #682

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jan 15, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 065e1f6 into kubeflow:master Jan 15, 2019
@rileyjbauer rileyjbauer deleted the add-usage-reporting-link branch May 6, 2019 22:17
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Tekton pipeline client should use generate name

* Use generateName to generate names for pipelines; we can use labels
  to attach semantic/metadata information to the pipeline.

Related to kubeflow#682: tekton_client.py submitting pipelineruns with names that
 are too long

* tekton_client should use PythonFire to generate the CLI rather
  than arg parser.

* Print stacktrace.

* Fix label.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants