feat: upgrade argo to v3.1.14 #6809
Conversation
google-oss-robot
requested review from
Ark-kun,
capri-xiyue,
chensun and
dushyanthsc
| @@ -1,5 +1,5 @@ | |||
| # Generated by https://github.com/google/go-licenses/v2. DO NOT EDIT. | |||
| github.com/argoproj/argo-workflows/v3, https://github.com/argoproj/argo-workflows/blob/v3.1.2/LICENSE, Apache-2.0 | |||
| github.com/argoproj/argo-workflows/v3, https://github.com/argoproj/argo-workflows/blob/v3.1.6/LICENSE, Apache-2.0 | |||
There was a problem hiding this comment.
This is unexpected, can you dig into the script to verify which argo repo version you used to generate licenses.
There was a problem hiding this comment.
After some research, looks like I need to manually update go-licenses.yaml for the new version. With the new license csv, I pushed the new images to gcr.io. At the meantime, I found that I need to change /Dockerfile.argoexec and /Dockerfile.workflow-controller as well.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat: upgrade argo to v3.1.14 * go mod tidy * fix license versions
* feat: upgrade argo to v3.1.14 * go mod tidy * fix license versions
Description of your changes:
Note: Need review on
kubeflow/pipelines/third_party/argo/licenses-argoexec.csvandkubeflow/pipelines/third_party/argo/licenses-workflow-controller.csv. Argo version is not completely matched after runningkubeflow/pipelines/third_party/argo/imp-1-update-notices.shChecklist: