Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update change log #657

Merged
merged 1 commit into from
Jan 10, 2019
Merged

update change log #657

merged 1 commit into from
Jan 10, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jan 9, 2019

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Jan 9, 2019

/assign @yebrahim

@yebrahim
Copy link
Contributor

yebrahim commented Jan 9, 2019

/lgtm
Is there a way to automate these? We don't want to be doing this manually for every merge, no?

@IronPan
Copy link
Member Author

IronPan commented Jan 10, 2019

/approve
This is updated only when creating a release, instead of every merge.

@IronPan
Copy link
Member Author

IronPan commented Jan 10, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0641e46 into master Jan 10, 2019
@IronPan IronPan deleted the release branch January 16, 2019 23:32
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Create a blueprint reconciler to autodeploy and reconcile
blueprints.

  * The reconciler decides whether we need to deploy a new blueprint
    and if it does it creates a Tekton PipelineRun to deploy Kubeflow.

* Here are some differences in how we are deploying blueprints vs. kfctl
  deployments

  * We are using Tekton PipelineRuns as opposed to K8s jobs to do the
    deployment

  * We no longer use deployments.yaml to describe the group of deployments.
    Instead we just create a PipelineRun.yaml and that provides all
    the information the reconciler needs e.g. the branch to watch
    for changes.

* Update the flask app to provide information about blueprints.
  * Include a link to the Tekton dashboard showing the PipelineRun
    that deployed Kubeflow.

* Define a Pipeline to deploy Kubeflow so we don't have to inline the
  spec in the PipelienRun.

* Remove Dockerfile.skaffold; we can use skaffold auto-sync in developer mode. Add a column in the webserver to redirect to the Tekton dashboard for the PipelineRun that deployed it.

* GoogleCloudPlatform/kubeflow-distribution#5 Setup autodeploy for gcp blueprints.
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* The reconciler is running amok because in kubeflow#657 we changed the code
  to skip over deployments with no manifest field because we couldn't get
  the zone. It turns out the lack of the manifest is an indication that
  the deployment failed. By not matching these deployments we end
  up retrying the auto-deployment. This is causing a cascading failure
  because we end up using up all our DM quota which in turn causes auto
  deployments to fail which in turn causes us to try again and eat up
  more deployments.

* This PR fixes that by matching deployments even if the manifest field
  is missing. This should prevent us from repeatedly retrying.

* Add exponential backoff to delete deployments. Because of the above
  error we are bumping to write quota limits per day which is impacting
  our ability to GC deployments.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Added additional license info for python libraries

* Added license file to images

*  Copied to correct image

* Trying changes to dockerfileS

* Removing go builds for now

* Added third_party to docker builds
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Signed-off-by: Michalina Kotwica <michalina.kotwica.ibm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants