Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple filtering by name to CustomTable #656

Merged
merged 6 commits into from
Jan 10, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jan 9, 2019

All lists, excluding the "last 5 runs" within the experiment list, will now include a filter bar.

Initially, filtering will be limited to the "name" column for each resource and will look for matching substrings, so "xgb" and "oos" will both match "xgboost-1".

This PR partially addresses #257


This change is Reviewable

@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-build-image

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some minor comments.

frontend/src/components/CustomTable.test.tsx Outdated Show resolved Hide resolved
frontend/src/components/CustomTable.test.tsx Show resolved Hide resolved
frontend/mock-backend/mock-api-middleware.ts Outdated Show resolved Hide resolved
frontend/src/components/CustomTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/CustomTable.tsx Outdated Show resolved Hide resolved
@yebrahim
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 705d000 into kubeflow:master Jan 10, 2019
@rileyjbauer rileyjbauer deleted the add-simple-filtering branch May 6, 2019 22:17
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update main README

* Add concepts and data plane

* Fix links

* KFServing quick start

* Remove samples to separate README

* Fix quick start

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants