-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple filtering by name to CustomTable #656
Add simple filtering by name to CustomTable #656
Conversation
/test kubeflow-pipeline-build-image |
8efb2fc
to
023794f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, some minor comments.
337cf59
to
b67827c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update main README * Add concepts and data plane * Fix links * KFServing quick start * Remove samples to separate README * Fix quick start * Update docs
All lists, excluding the "last 5 runs" within the experiment list, will now include a filter bar.
Initially, filtering will be limited to the "name" column for each resource and will look for matching substrings, so "xgb" and "oos" will both match "xgboost-1".
This PR partially addresses #257
This change is