Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "create" rather than "start" except when initiating a run #650

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jan 8, 2019

This PR fixes the terminology related to making new runs and experiments so that "Create" is used when reaching either of the "new" forms, and "start" is only used for the button to begin executing a new run.

Fixes #649


This change is Reviewable

…n a static object (experiment). 'Start' is used solely for initiating runs
@rileyjbauer rileyjbauer changed the title Use Create except when initiating a run Use "create" rather than "start" except when initiating a run Jan 8, 2019
@rileyjbauer
Copy link
Contributor Author

/assign yebrahim
/area front-end

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d966554 into kubeflow:master Jan 9, 2019
@rileyjbauer rileyjbauer deleted the create-vs-start branch May 6, 2019 22:16
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* add self-signed ca script for dev

* change env name
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "Start" for runs, "Create" for experiments
3 participants