Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating OWNER files. Adding per-subdirectory OWNER files. #65

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Updating OWNER files. Adding per-subdirectory OWNER files. #65

merged 3 commits into from
Nov 5, 2018

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Nov 5, 2018 •
edited by jlewi
Loading

This change is Reviewable

@vicaire vicaire requested a review from IronPan November 5, 2018 22:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vicaire

If they are not already assigned, you can assign the PR to them by writing /assign @vicaire in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

IronPan
IronPan approved these changes Nov 5, 2018
View reviewed changes
vendor/OWNERS
- IronPan
- qimingj
- yebrahim
reviewers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is go specific. can you add hongye

@vicaire vicaire merged commit 1b1ded2 into master Nov 5, 2018
@google-prow-robot
Copy link
Collaborator

@vicaire: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-presubmit-sample-test 1f15758 link /test mlpipeline-presubmit-sample-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@IronPan IronPan deleted the vicaire/test3 branch June 4, 2019 07:30
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@lluunn @k8s-ci-robot
Fix Dockerfile for testing image (kubeflow#65)
79c5f16 
* fix

* use ks 0.9.1
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun @k8s-ci-robot
Introduce KO for fast development iteration (kubeflow#65)
c178dd7 
* ko requires controller manifest to be separated out

* Add deploy-test makefile recipe for fast dev develop and deploy for testing

* Add image patch script for development overlay

* Consolidate to deploy-dev
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
@Tomcli
Add more k8s resource support (#65)
f088d2a 
* add more k8s resource support

* add test main functions as requested

* add description on why we need pipelinerun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vicaire @k8s-ci-robot @google-prow-robot @IronPan @jaKjH101