Updates material-ui and react npm libraries #630
Conversation
frontend/package.json
Outdated
| @@ -12,10 +12,11 @@ | |||
| "dagre": "^0.8.2", | |||
| "http-proxy-middleware": "^0.19.0", | |||
| "immer": "^1.7.4", | |||
| "jss": "^10.0.0-alpha.3", | |||
There was a problem hiding this comment.
No, this is a workaround for mui/material-ui#14040. Once that issue is fixed, we should be able to remove this direct dep
There was a problem hiding this comment.
Ah interesting.
You can consider using an older version (e.g. 3.7.x) that moves us very close to being updated without needing this hack. Keep in mind that even with the latest, we'll be outdated again in just a week or two. Up to you tho.
There was a problem hiding this comment.
I set it to 3.7.1 so we don't need the workaround, but we'll need to remember to update it in the future
There was a problem hiding this comment.
+1. It's good to update all of our dependencies every now and then if the update is cheap.
|
/lgtm |
|
/test kubeflow-pipeline-build-image |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…15 (kubeflow#630) * Update to serving 0.11 * Resolve dep * Fix istio dependency * Add webhook vendor * Fix istio types * Fix codegen * Register webhook * Setup admission webhook manifests * Fix webhook and install cert manager * Disable metrics server in test * Wait sometime for installing cert manager * Fix crd path * Add back addressable type * Remove xgb build for now * Add back xgbserver build * rebase for v1 api * Add object selector * Add doc for installing cert manager * Update readme
Most changes are adding
variant='outlined'to all of the inputs. It seems we can no longer extendTextFieldPropsdirectly due to its lack of compile time typing: "An interface can only extend an object type or intersection of object types with statically known members."We can extend
OutlinedTextFieldPropsdirectly to avoid this, but it hasvariantas a required field, hence all of the additions.This change is