Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pipeline and job python client as part of SDK #628

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jan 4, 2019

So people can use python to CRUD pipeline or job, from for example notebook.


This change is Reviewable

So people can use python to CRUD pipeline or job
@IronPan
Copy link
Member Author

IronPan commented Jan 4, 2019

fix #617

@IronPan
Copy link
Member Author

IronPan commented Jan 4, 2019

/assign @qimingj @yebrahim

@gaoning777
Copy link
Contributor

How about adding another function: upload_pipeline in the SDK to fix #617?
Wrapping the swagger interface helps to reduce friction for python SDK usage.

@qimingj
Copy link
Contributor

qimingj commented Jan 4, 2019

Ditto @gaoning777. This is fine as the first step and we'll need a wrapper. We also need to add the packages in setup.py (https://github.com/kubeflow/pipelines/blob/master/sdk/python/setup.py)

@qimingj
Copy link
Contributor

qimingj commented Jan 4, 2019

We can probably do the wrapper and add those to setup.py in a separate change.

@qimingj
Copy link
Contributor

qimingj commented Jan 4, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Jan 4, 2019

/test kubeflow-pipeline-build-image

@IronPan
Copy link
Member Author

IronPan commented Jan 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Jan 4, 2019

thanks i always forgot setup.py. I'll add it separately

@k8s-ci-robot k8s-ci-robot merged commit 5912488 into master Jan 4, 2019
IronPan added a commit that referenced this pull request Jan 4, 2019
This is a follow up PR after #628
@IronPan IronPan deleted the IronPan-patch-1 branch January 4, 2019 23:54
k8s-ci-robot pushed a commit that referenced this pull request Jan 5, 2019
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants