Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Surface kubernetes configuration in container builder #6095

Conversation

casassg
Copy link
Contributor

@casassg casassg commented Jul 21, 2021

Description of your changes:

Python Kubernetes SDK doesn't handle well tokens that expire. GCP default authentication has set its own custom refresh token, but for other kubernetes API authentication mechanisms it's not trivial to implement.

In order to customize authentication, users of the python sdk can customize the client configuration object to set a custom refresh_api_key_hook and provide it to load_kube_config.

With this change, in ContainerBuilder, we can inject a custom client configuration that will be used by the client to check the kaniko execution.

I avoided setting it for load_incluster_config as usually that uses the internal token provider in the cluster and therefore has less need to be customized. To avoid confusion, I can name it kubernetes_outcluster_configuration?

Related issues: kubernetes-client/python#741

@google-oss-robot
Copy link

Hi @casassg. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@casassg casassg force-pushed the gcasassaez/surface_kubernetes_configuration branch from f124066 to 6647d36 Compare July 23, 2021 01:50
@casassg
Copy link
Contributor Author

casassg commented Jul 23, 2021

/assign @ji-yaqi

Assigning as PR is pretty small (lmk whats the acceptable process for this in the future pls)

@casassg
Copy link
Contributor Author

casassg commented Aug 2, 2021

rebumping this up!

@casassg
Copy link
Contributor Author

casassg commented Aug 17, 2021

@chensun any chance to check this one? Im happy to close if deemed not appropriate

@chensun
Copy link
Member

chensun commented Aug 17, 2021

/ok-to-test

@chensun
Copy link
Member

chensun commented Aug 17, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit eb41fdd into kubeflow:master Aug 17, 2021
@casassg casassg deleted the gcasassaez/surface_kubernetes_configuration branch August 17, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants