-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifests for CRD, examples #6
Conversation
Hi @ynqa. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jlewi |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* # This is a combination of 6 commits. # This is the 1st commit message: Modify agent test case for code coverage (kubeflow#1849) * Modifies the test case for sync models config Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> # This is the commit message kubeflow#2: Add test cases for agent storage utils (kubeflow#1849) * Add test case for FileExists function * Add test case for RemoveDir function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> # This is the commit message kubeflow#3: Add test case for agent storage utils * Add test case for GetProvider function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> # This is the commit message kubeflow#4: Add test case for gcs model downloader (kubeflow#1849) * Add test case for gcs model downloader in agent Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> # This is the commit message kubeflow#5: Add test cases for agent downloader Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> # This is the commit message kubeflow#6: Add test cases for configmap (kubeflow#1849) * Add test cases for v1beta1 configmap Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Add test cases for inference service defaults (kubeflow#1849) * Add test cases for all model runtimes * Add test cases for all runtime defaults Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * fmt (kubeflow#1849) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Modify agent test case for code coverage (kubeflow#1849) * Modifies the test case for sync models config Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for agent storage utils (kubeflow#1849) * Add test case for FileExists function * Add test case for RemoveDir function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test case for agent storage utils * Add test case for GetProvider function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test case for gcs model downloader (kubeflow#1849) * Add test case for gcs model downloader in agent Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for agent downloader Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for configmap (kubeflow#1849) * Add test cases for v1beta1 configmap Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for inference service defaults (kubeflow#1849) * Add test cases for all model runtimes * Add test cases for all runtime defaults Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for predictor model (kubeflow#1849) * Add test cases for isFrameworkSupported function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for sklearn predictor (kubeflow#1849) * Add test cases for GetProtocol function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for configmap (kubeflow#1849) * Add test case for creating empty model config Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for utils (kubeflow#1849) * Add test cases for IncludesArg function * Add test cases for IsGPUEnabled function * Add test cases for FirstNonNilError function * Add test cases for RemoveString function * Add test cases for IsPrefixSupported function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Add test cases for creds_utils (kubeflow#1849) * Add test cases for set_gcs_credentials function * Add test cases for create_secret function * Add test cases for set_service_account function * Add test cases for create_service_account function * Add test cases for patch_service_account function * Add test cases for get_creds_name_from_config_map function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Add test cases for creds_utils (kubeflow#1849) * Add test cases for set_gcs_credentials function * Add test cases for create_secret function * Add test cases for set_service_account function * Add test cases for create_service_account function * Add test cases for patch_service_account function * Add test cases for get_creds_name_from_config_map function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for creds_utils (kubeflow#1849) * Add test cases for set_s3_credentials function * Add test cases for set_azure_credentials function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for v1beta1 component (kubeflow#1849) * Add test cases for validateStorageSpec function * Add test cases for validateLogger function * Add test cases for FirstNonNilComponent function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for inference service status (kubeflow#1849) * Add test cases for PropagateRawStatus function * Add test cases for PropagateStatus function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for predictor (kubeflow#1849) * Add test cases for GetPredictorImplementations function * Add test cases for GetPredictorImplementation function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for agent_injector (kubeflow#1849) * Add test cases for getLoggerConfigs function * Add test cases for getAgentConfigs function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for batcher_injector (kubeflow#1849) * Add test cases for getBatcherConfigs function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Add test cases for storage initializer injector (kubeflow#1849) * Add test cases for getStorageInitializerConfigs function * Add test cases for parsePvcUri function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for storage initializer injector (kubeflow#1849) * Add test cases for parsePvcUri function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> fmt (kubeflow#1849) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Add test cases for controller utils (kubeflow#1849) * Add test cases for GetDeploymentMode function Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Remove double import of same package (kubeflow#1849) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> temp commit Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Updated coverage for inference_service_default_test Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Added scripts for code coverage Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Updated make to track coverage including subpackages Added more coverage Added ignore to client package - generated code Added coverage script to workflow Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Temporarily commenting couple of test cases Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Temporary changes to debug e2e Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Commented configmap test Reverted accidental commit of generated code. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Added -v to debug failing tests Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Updated tests to remove dependency on k8s cluster Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Updated readme to show coverage
transfer actions from dsp tekton.
Add manifests to run
scheduledworkflows
and its examples.for examples:
This change is