Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Components - Added support for annotations to create_graph_component_from_pipeline_func #5991

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 8, 2021

This functionality already exists in create_component_from_func adding it to create_graph_component_from_pipeline_func as well.

@chensun
Copy link
Member

chensun commented Jul 8, 2021

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 8, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 13, 2021

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 15, 2021

/retest

@google-oss-robot
Copy link

google-oss-robot commented Jul 15, 2021

@Ark-kun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 403acba link /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 15, 2021

/retest

@Ark-kun Ark-kun merged commit 9b679c5 into kubeflow:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants