Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return resource count from ListXXX calls #595

Merged
merged 17 commits into from
Jan 31, 2019
9 changes: 7 additions & 2 deletions backend/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Pipelines backend.

## Building & Testing
All components can be built using [Bazel](https://bazel.build/). To build
everything under bazel, run:
everything under backend, run:
```
bazel build //backend/...
```
Expand All @@ -13,6 +13,11 @@ To run all tests:
bazel test //backend/...
```

## Building Go client library and swagger files
After making changes to proto files, the Go client libraries and swagger
files need to be regenerated and checked-in. The backend/api/generate_api.sh
script takes care of this.

## Updating BUILD files
As the backend is written in Go, the BUILD files can be updated automatically
using [Gazelle](https://github.com/bazelbuild/bazel-gazelle). Whenever a Go
Expand All @@ -27,4 +32,4 @@ bumped in the `go.mod` file, ensure the BUILD files pick this up by updating
the WORKSPACE go_repository rules using the following command:
```
bazel run //:gazelle -- update-repos --from_file=go.mod
```
```
1 change: 1 addition & 0 deletions backend/api/experiment.proto
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ message ListExperimentsRequest {

message ListExperimentsResponse {
repeated Experiment experiments = 1;
int32 total_size = 3;
string next_page_token = 2;
}

Expand Down
107 changes: 58 additions & 49 deletions backend/api/go_client/experiment.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading