Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment - Minikube support - Passing the platform parameter to kfctl #588

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Deployment - Minikube support - Passing the platform parameter to kfctl #588

merged 1 commit into from
Jan 2, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Dec 22, 2018 •
edited by jlewi
Loading

/assign @IronPan

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Dec 22, 2018

is this for minikube?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 26, 2018

is this for minikube?

Yes. Kubeflow has Minikube deployment support.

@Ark-kun Ark-kun changed the title Deployment - Passing the platform parameter to kfctl Deployment - Minikube support - Passing the platform parameter to kfctl Dec 26, 2018
@IronPan
Copy link
Member

IronPan commented Jan 2, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d135be9 into kubeflow:master Jan 2, 2019
@Ark-kun Ark-kun deleted the Deployment---Passing-the-platform-parameter branch January 21, 2019 11:19
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@avdaredevil
Introduced Node-License CLI (kubeflow#588)
053de89 
- Full featured cli with cmdline support
- Installable as a CLI after clone
- Readme added to explain installation/run steps
- Semaphore based ratelimiter to not exceed calls per sec
- Retry enabled calls to Github to retry on fail
- Single entrypoint with modular design to add more commands down the line
- Help menu
- Runtime transpiler to allow es6
- Verbose output
- Graceful handling of errors
- Promise chains baked to handle errors at each level
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@Tomcli @k8s-ci-robot
Fix docs typos (kubeflow#588)
b502d12
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli @drewbutlerbb4
Add Custom Task Docs and Usage (kubeflow#588)
5b29a7f 
* add initial custom task docs

* remove regex

* add custom task condition benefits

* add toc

* Apply suggestions from code review

Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>

* add hyperlinks

* add descriptions for custom tasks

* Update advanced_user_guide.md

* Update README.md

* Update advanced_user_guide.md

Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@IronPan IronPan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ark-kun @IronPan @k8s-ci-robot