Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds secrets to ml-pipeline-ui-artifact deployments in user profiles #5864

Conversation

bjmask
Copy link
Contributor

@bjmask bjmask commented Jun 15, 2021

Description of your changes:

Checklist:

@google-cla
Copy link

google-cla bot commented Jun 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-oss-robot
Copy link

Hi @andres-de-castro. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented Jun 29, 2021

Hi @andres-de-castro, can you sign the CLA first?
Thanks

@bjmask
Copy link
Contributor Author

bjmask commented Jul 1, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 1, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jul 3, 2021

Copy link
Contributor

@jacobmalmberg jacobmalmberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see review / code below.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zijianjoy after the PR has been reviewed.
You can assign the PR to them by writing /assign @zijianjoy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zijianjoy
Copy link
Collaborator

/ok-to-test

@zijianjoy
Copy link
Collaborator

Hello @andres-de-castro , would you like to apply the comment in this PR? We can merge this PR once it is applied. This can unblock KFP issues like #6750, #6839

…-controller/sync.py

Co-authored-by: Jacob Malmberg <jacobmalmberg@gmail.com>
Comment on lines +322 to +330
{
"name": "MINIO_ACCESS_KEY",
"value": mlpipeline_minio_access_key
},
{
"name": "MINIO_SECRET_KEY",
"value": mlpipeline_minio_secret_key
}
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part can be removed now

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c6c826d into kubeflow:master Dec 17, 2021
@zijianjoy
Copy link
Collaborator

Addressing open comments in #7087

abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
…files (kubeflow#5864)

* added minio credentials to UI deploy

* Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py

Co-authored-by: Jacob Malmberg <jacobmalmberg@gmail.com>

Co-authored-by: Jacob Malmberg <jacobmalmberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants