-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds secrets to ml-pipeline-ui-artifact deployments in user profiles #5864
feat: adds secrets to ml-pipeline-ui-artifact deployments in user profiles #5864
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @andres-de-castro. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @andres-de-castro, can you sign the CLA first? |
@googlebot I signed it! |
Hi @andres-de-castro, can you confirm whether any tests need an update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see review / code below.
manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
…-controller/sync.py Co-authored-by: Jacob Malmberg <jacobmalmberg@gmail.com>
{ | ||
"name": "MINIO_ACCESS_KEY", | ||
"value": mlpipeline_minio_access_key | ||
}, | ||
{ | ||
"name": "MINIO_SECRET_KEY", | ||
"value": mlpipeline_minio_secret_key | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part can be removed now
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addressing open comments in #7087 |
…files (kubeflow#5864) * added minio credentials to UI deploy * Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py Co-authored-by: Jacob Malmberg <jacobmalmberg@gmail.com> Co-authored-by: Jacob Malmberg <jacobmalmberg@gmail.com>
Description of your changes:
Checklist: