Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend - Removed hardcoded metrics file name #574

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Backend - Removed hardcoded metrics file name #574

merged 3 commits into from
Dec 21, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Dec 20, 2018 •
edited
Loading

Prerequisite for generic artifact support.

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 20, 2018

/assign @IronPan

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 20, 2018

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 20, 2018

/assign @hongye-sun

hongye-sun
hongye-sun approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 20, 2018
@IronPan
Copy link
Member

IronPan commented Dec 21, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c33c62f into kubeflow:master Dec 21, 2018
@Ark-kun Ark-kun deleted the Backend---Removed-hardcoded-metrics-file-name branch January 21, 2019 11:19
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Remove Kubeflow configs for the old kf-releasing cluster (kubeflow#574)
bb549cb 
* This cluster is no longer used (See kubeflow#573). These configs refer to
  a very old Kubeflow config; i.e. still using ksonnet.

* Related to kubeflow#573
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@drewbutlerbb4 @Tomcli
fix(ui, backend) Add pipelineRun to cache to assist in finding artifa…
8b289ce 
…ct data (kubeflow#574)

* Add pipelineRun to cache for finding artifact data

* Remove extra container and account for custom tasks in frontend

* Apply suggestions from code review

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun approved these changes

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@IronPan IronPan

@hongye-sun hongye-sun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @IronPan @k8s-ci-robot @hongye-sun