Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating runs with no experiments #572

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 19, 2018

Removes the experiment reference validation, and adds a test. Fixes #560.

/assign @IronPan
/area back-end


This change is Reviewable

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ca22c29 into kubeflow:master Dec 20, 2018
@yebrahim yebrahim deleted the no-experiment branch December 21, 2018 04:34
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Define a v0.8 release

* Update applications.yaml with a v0.8 release.

* The purpose of this PR is to check that just by defining the appropriate
  release we can begin building images from release branches and updating
  the release branch of kubeflow/manifests

* Related to kubeflow/testing#450 - Continuous delivery of Kubeflow applications

* Create a python script for opening up the PR; this script replaces
  the bash script rebuild-manifests.sh that was used previously

* The new script doesn't assume that the base branch for PRs is master.
  We need this to support updating release branches.

* Create a profile in skaffold.yaml for running on the release cluster.
* Create an image_util package to parse image URLs.

* Use the Docker image for apps-cd to run create_manifests_pr.py
  * Add kustomize, go, and some other tools we need

  * In the docker image create a symbolic link for .ssh so we can pick
    up ssh credentials created by Tekton.

* * Define a 1.0 release now that the branches have been cut
  * Related to kubeflow/kubeflow#4685
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…w#572)

* enchance error messages

* update logs

* update logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants