Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend mock data after proto changes #564

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 18, 2018

Follow up on https://github.com/kubeflow/pipelines/pull/524/files. The namespace field has been removed from the proto, but it's still in the mock data for the frontend, so the project fails to build.

/assign @IronPan
/assign @neuromage
/area front-end


This change is Reviewable

@neuromage
Copy link
Contributor

/lgtm

@yebrahim
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 09dbf5f into kubeflow:master Dec 18, 2018
@yebrahim yebrahim deleted the patch-1 branch December 19, 2018 06:24
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
… CD. (kubeflow#564)

* Run update_kf_apps.py continuously in a K8s deployment so that
  Tekton pipelineruns are continuously created as needed.

* The server uses update_launcher.py to update a clone of kubeflow/testing
  before calling update_kf_apps.py. This way it picks up the latest code
  and config before running update_kf_apps.py

* Create a skaffold config for running the launcher to create the CD pipelines.

  * Useful for debugging and deployment.

Related to kubeflow#450 continuous updating of Kubeflow applications.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* Update any-sequencer dependency parsing

* Update formatting

* Add checks for tasks that have not ran yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants