-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): PyTorch - Added the Create PyTorch Model Archive component #5630
feat(components): PyTorch - Added the Create PyTorch Model Archive component #5630
Conversation
Can someone please take a look? |
sorry, somehow I missed this during a busy period. I will take a look tomorrow. |
/lgtm /hold |
@Bobgy: GitHub didn't allow me to request PR reviews from the following users: chauhang. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR has been pending the review for almost a month. Speaking about #5780, I do not see any KFP component there. I also do not see any KFP sample pipeline that uses a component. I feel that anyone should be free to create their components, so I'm fine with the existence of (even though I do not fully understand its purpose). However I feel that this should be reciprocal - I do not think that some later PR (#5780) should block this PR. |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipelines-samples-v2 |
1 similar comment
/test kubeflow-pipelines-samples-v2 |
@Ark-kun: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test kubeflow-pipelines-samples-v2 |
The kubeflow-pipelines-samples-v2 tests actually succeed. So I'm merging this PR. |
No description provided.