Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode filter parameter as a base64-encoded JSON string in List requests #563

Merged
merged 12 commits into from
Jan 2, 2019
Merged

Encode filter parameter as a base64-encoded JSON string in List requests #563

merged 12 commits into from
Jan 2, 2019

Commits on Dec 23, 2018

  1. Make all ListXXX operations use POST instead of GET. 

    Generate new swagger definitions and use these to generate the frontend
APIs using `npm run apis`.

This is to support filtering in List requests, as the current
grpc-gateway swagger generator tool does not support repeated fields in
requests used in GET endpoints.
    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    25f6439 View commit details
    Browse the repository at this point in the history

  2. Use base64-encoded JSON-stringified version of Filter instead. 

    This lets us keep filter as a simple parameter in the ListXXX requests,
and gets around having to use POST for List requests.
    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    730933f View commit details
    Browse the repository at this point in the history

  3. refactor filter parsing to parseAPIFilter and add tests

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    296c8ab View commit details
    Browse the repository at this point in the history

  4. Hack to ensure correct Swagger definitions are generated for Filter.

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    b05cbea View commit details
    Browse the repository at this point in the history

  5. Fix merge conflicts with master after rebase

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    a641a7b View commit details
    Browse the repository at this point in the history

  6. fix indentation

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    0e653a9 View commit details
    Browse the repository at this point in the history

  7. Fix hack so frontend apis compile.

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    830b275 View commit details
    Browse the repository at this point in the history

  8. print failing experiments

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    37951a7 View commit details
    Browse the repository at this point in the history

  9. try print again.

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    e9125b6 View commit details
    Browse the repository at this point in the history

  10. revert experiment_api_test

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    1ce0457 View commit details
    Browse the repository at this point in the history

  11. Use StdEncoding for base64 encoding

    @neuromage
    neuromage committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    7ceddfa View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Fix nil pointer dereference error caused err variable shadowing

    @neuromage
    neuromage committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    48608a9 View commit details
    Browse the repository at this point in the history