Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample test failure #548

Merged
merged 10 commits into from
Dec 19, 2018
Merged

Fix sample test failure #548

merged 10 commits into from
Dec 19, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 17, 2018 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777 gaoning777 mentioned this pull request Dec 17, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented Dec 17, 2018

Is this ready for review? If so can you remove WIP from the title.

@gaoning777
Copy link
Contributor Author

Not yet. I need to check the test results to make sure no more fixes are needed.
once that is done, I will remove the WIP

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@hongye-sun
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 17, 2018
@gaoning777 gaoning777 mentioned this pull request Dec 17, 2018
Closed
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

2 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777 gaoning777 changed the title [WIP] Fix sample test failure Fix sample test failure Dec 19, 2018
@gaoning777
Copy link
Contributor Author

Together with #565, the sample test failure should be fixed.

@qimingj
Copy link
Contributor

qimingj commented Dec 19, 2018

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-build-image

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-unit-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-unit-test
/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 2118baf into kubeflow:master Dec 19, 2018
@gaoning777 gaoning777 deleted the sample-test-fix branch December 19, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@qimingj qimingj

@hongye-sun hongye-sun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaoning777 @jlewi @hongye-sun @qimingj @k8s-ci-robot