Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend - Added modern time formatters #5464

Merged
merged 13 commits into from
May 20, 2021

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 13, 2021

Placeholder format: {{$.scheduledTime.strftime('%Y-%m-%d')}}

Placeholder format: `{{$.scheduledTime.strftime('%Y-%m-%d')}}`
@google-oss-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 13, 2021

/test kubeflow-pipeline-backend-test

@Bobgy
Copy link
Contributor

Bobgy commented Apr 18, 2021

@Ark-kun thank you! This is awesome 😎

Do you need any help finishing this?

@Ark-kun Ark-kun marked this pull request as ready for review April 23, 2021 08:52
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 15, 2021

Sorry for the delay. Fixed the regex bug.
The backend test now passes.

@Bobgy
Copy link
Contributor

Bobgy commented May 16, 2021

Thank you so much!
I will review next week

@Bobgy
Copy link
Contributor

Bobgy commented May 19, 2021

/lgtm
/approve
Good point, we can change time zone in a separate PR

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 584d5e5 into master May 20, 2021
@google-oss-robot google-oss-robot deleted the Backend---Added-modern-time-formatters branch May 20, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants