Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Shorten output names #5408

Merged
merged 1 commit into from
Apr 5, 2021
Merged

feat(frontend): Shorten output names #5408

merged 1 commit into from
Apr 5, 2021

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 1, 2021

No description provided.

@Ark-kun Ark-kun requested review from Bobgy and zijianjoy April 1, 2021 02:21
@google-oss-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-cla google-cla bot added the cla: yes label Apr 1, 2021
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 1, 2021

/test all

@Ark-kun Ark-kun force-pushed the Frontend---Shorten-output-names branch from 5efb299 to 45aa10e Compare April 4, 2021 01:15
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 4, 2021

/test kubeflow-pipeline-frontend-test

@Ark-kun Ark-kun force-pushed the Frontend---Shorten-output-names branch from 45aa10e to be22d6e Compare April 4, 2021 01:48
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 4, 2021

/test kubeflow-pipeline-frontend-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 4, 2021

/test kubeflow-pipeline-frontend-test

@Ark-kun Ark-kun force-pushed the Frontend---Shorten-output-names branch from be22d6e to 8e4a5a6 Compare April 4, 2021 01:55
@Ark-kun Ark-kun marked this pull request as ready for review April 4, 2021 02:01
@Bobgy
Copy link
Contributor

Bobgy commented Apr 5, 2021

Thank you!
/LGTM

/assign @zijianjoy

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 5, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 5c27e7c into kubeflow:master Apr 5, 2021
@Bobgy Bobgy mentioned this pull request Apr 20, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@StefanoFioravanzo StefanoFioravanzo Awaiting requested review from StefanoFioravanzo

Assignees

@Bobgy Bobgy

@zijianjoy zijianjoy

Labels
approved area/frontend cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @google-oss-robot @Bobgy @zijianjoy