fix persistence agent to use in cluster DNS instead of kube proxy to access API #538
Conversation
| mlPipelineServiceName string, | ||
| mlPipelineServiceHttpPort string, | ||
| mlPipelineServiceGRPCPort string) (*PipelineClient, error) { | ||
| addressTemp := "%s.%s.svc.cluster.local:%s" |
There was a problem hiding this comment.
Could you make this a constant?
|
/lgtm One small comment. Feel free to approve yourself. |
|
/lgtm |
|
@IronPan: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@IronPan: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
the kfp-tekton install manifest already includes tekton, therefore, remove the tekton deploy/undeploy tasks also add tasks to build cacheserver and frontend
This change is