fix(sdk): Local runner - Fixed the local runner on Windows #5313
Conversation
Sume of the fixed issues could also affect Linux OSes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| """Construct the instance of LocalClient | ||
|
|
||
| Args： | ||
| pipeline_root: The root directory where the output artifact of component | ||
| will be savad. | ||
| """ | ||
| pipeline_root = pipeline_root or tempfile.tempdir |
There was a problem hiding this comment.
Shall we consider warning users when this is default to None? Because one of the reason we have pipeline root is to ensure the artifacts generated during the pipeline execution get persistent somewhere, and using tempfile is 'against' this purpose
There was a problem hiding this comment.
Interesting idea. I can try adding a warning.
Although in this PR I'm not changing the behavior - just changing the default from /tmp to the portable tempdir.
|
/LGTM |
Some of the issues also affected Linux.