Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "namespace" param to "host" in kfp client so we can use Jupyter outside cluster. #529

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Dec 12, 2018

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 12, 2018

Thanks for fixing this!
/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 12, 2018

/test kubeflow-pipeline-e2e-test

@qimingj
Copy link
Contributor Author

qimingj commented Dec 13, 2018

/approve

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 13, 2018

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Dec 13, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6b315d4 into kubeflow:master Dec 13, 2018
@gaoning777
Copy link
Contributor

thanks bradley

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* update e2e pattern

* delete all instance groups not in use

* revert pattern

* update

* update

* move back policy

* update
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants