Skip backend integration tests when cli flag isn't passed

backend/test/cli_test.go

@@ -16,22 +16,13 @@ import (
 const (
 	defaultPageSize    = int32(10)
 	myUploadedPipeline = "my-uploaded-pipeline"
-	// If true, run as a unit test using a fake client.
-	// If false, run as an integration test calling the service.
-	// This is useful to test locally before running an e2e test (which takes a while).
-	// IMPORTANT: This should always be set to FALSE in the checked-in code.
-	runAsUnitTest = false
 )
 
 func GetRealRootCommand() (*cmd.RootCommand, cmd.ClientFactoryInterface) {
-	if runAsUnitTest {
-		return cmd.GetFakeRootCommand()
-	} else {
-		clientFactory := cmd.NewClientFactoryWithByteBuffer()
-		rootCmd := cmd.NewRootCmd(clientFactory)
-		rootCmd = cmd.CreateSubCommands(rootCmd, defaultPageSize)
-		return rootCmd, clientFactory
-	}
+	clientFactory := cmd.NewClientFactoryWithByteBuffer()
+	rootCmd := cmd.NewRootCmd(clientFactory)
+	rootCmd = cmd.CreateSubCommands(rootCmd, defaultPageSize)
+	return rootCmd, clientFactory
 }
 
 type CLIIntegrationTest struct {
@@ -41,15 +32,18 @@ type CLIIntegrationTest struct {
 
 // Check the cluster namespace has Kubeflow pipelines installed and ready.
 func (c *CLIIntegrationTest) SetupTest() {
+	if *runAsUnitTest {
+		c.T().SkipNow()
+		return
+	}
+
 	c.namespace = *namespace
 
-	if !runAsUnitTest {
-		// Wait for the system to be ready.
-		err := waitForReady(c.namespace, *initializeTimeout)
-		if err != nil {
-			glog.Exitf("Cluster namespace '%s' is still not ready after timeout. Error: %s", c.namespace,
-				err.Error())
-		}
+	// Wait for the system to be ready.
+	err := waitForReady(c.namespace, *initializeTimeout)
+	if err != nil {
+		glog.Exitf("Cluster namespace '%s' is still not ready after timeout. Error: %s", c.namespace,
+			err.Error())
 	}
 }
 

backend/test/experiment_api_test.go

@@ -22,6 +22,11 @@ type ExperimentApiTest struct {
 
 // Check the namespace have ML job installed and ready
 func (s *ExperimentApiTest) SetupTest() {
+	if *runAsUnitTest {
+		s.T().SkipNow()
+		return
+	}
+
 	err := waitForReady(*namespace, *initializeTimeout)
 	if err != nil {
 		glog.Exitf("Failed to initialize test. Error: %s", err.Error())

backend/test/job_api_test.go

@@ -34,6 +34,11 @@ type JobApiTestSuite struct {
 
 // Check the namespace have ML pipeline installed and ready
 func (s *JobApiTestSuite) SetupTest() {
+	if *runAsUnitTest {
+		s.T().SkipNow()
+		return
+	}
+
 	err := waitForReady(*namespace, *initializeTimeout)
 	if err != nil {
 		glog.Exitf("Failed to initialize test. Error: %s", err.Error())

backend/test/pipeline_api_test.go

@@ -32,6 +32,11 @@ type PipelineApiTest struct {
 
 // Check the namespace have ML job installed and ready
 func (s *PipelineApiTest) SetupTest() {
+	if *runAsUnitTest {
+		s.T().SkipNow()
+		return
+	}
+
 	err := waitForReady(*namespace, *initializeTimeout)
 	if err != nil {
 		glog.Exitf("Failed to initialize test. Error: %s", err.Error())
@@ -65,7 +70,7 @@ func (s *PipelineApiTest) TestPipelineAPI() {
 	/* ---------- Import pipeline YAML by URL ---------- */
 	time.Sleep(1 * time.Second)
 	sequentialPipeline, err := s.pipelineClient.Create(&params.CreatePipelineParams{
-		Body:  &pipeline_model.APIPipeline{URL:&pipeline_model.APIURL{
+		Body: &pipeline_model.APIPipeline{URL: &pipeline_model.APIURL{
 			PipelineURL: "https://storage.googleapis.com/ml-pipeline-dataset/sequential.yaml"}}})
 	assert.Nil(t, err)
 	assert.Equal(t, "sequential.yaml", sequentialPipeline.Name)
@@ -79,7 +84,7 @@ func (s *PipelineApiTest) TestPipelineAPI() {
 	/* ---------- Import pipeline tarball by URL ---------- */
 	time.Sleep(1 * time.Second)
 	argumentUrlPipeline, err := s.pipelineClient.Create(&params.CreatePipelineParams{
-		Body:  &pipeline_model.APIPipeline{URL:&pipeline_model.APIURL{
+		Body: &pipeline_model.APIPipeline{URL: &pipeline_model.APIURL{
 			PipelineURL: "https://storage.googleapis.com/ml-pipeline-dataset/arguments.tar.gz"}}})
 	assert.Nil(t, err)
 	assert.Equal(t, "arguments.tar.gz", argumentUrlPipeline.Name)

backend/test/run_api_test.go

@@ -28,6 +28,11 @@ type RunApiTestSuite struct {
 
 // Check the namespace have ML pipeline installed and ready
 func (s *RunApiTestSuite) SetupTest() {
+	if *runAsUnitTest {
+		s.T().SkipNow()
+		return
+	}
+
 	err := waitForReady(*namespace, *initializeTimeout)
 	if err != nil {
 		glog.Exitf("Failed to initialize test. Error: %s", err.Error())

backend/test/test_utils.go

@@ -39,6 +39,7 @@ import (
 
 var namespace = flag.String("namespace", "kubeflow", "The namespace ml pipeline deployed to")
 var initializeTimeout = flag.Duration("initializeTimeout", 2*time.Minute, "Duration to wait for test initialization")
+var runAsUnitTest = flag.Bool("unitTestsOnly", true, "Whether to skip integration tests that call the service")
 
 func waitForReady(namespace string, initializeTimeout time.Duration) error {
 	var operation = func() error {

test/api-integration-test/run_test.sh

@@ -61,7 +61,7 @@ TEST_DIR=backend/test
 cd "${BASE_DIR}/${TEST_DIR}"
 
 echo "Run integration test..."
-TEST_RESULT=`go test -v ./... -namespace ${NAMESPACE} 2>&1`
+TEST_RESULT=`go test -v ./... -namespace ${NAMESPACE} -args -unitTestsOnly=false 2>&1`
 TEST_EXIT_CODE=$?
 
 # Log the test result

test/backend-unit-test/run_test.sh

@@ -51,7 +51,7 @@ cd "${BASE_DIR}/${TEST_DIR}"
 
 # Run test and store the exit code.
 echo "Run unit test..."
-TEST_RESULT=`go test -v ./... 2>&1`
+TEST_RESULT=`go test -v ./... -args -unitTestsOnly=false 2>&1`
 TEST_EXIT_CODE=$?
 
 # Log the test result
@@ -62,4 +62,4 @@ printf '%s\n' "$TEST_RESULT" | go-junit-report > ${JUNIT_TEST_RESULT}
 echo "Copy test result to GCS ${RESULTS_GCS_DIR}/${JUNIT_TEST_RESULT}"
 gsutil cp ${JUNIT_TEST_RESULT} ${RESULTS_GCS_DIR}/${JUNIT_TEST_RESULT}
 
-exit $TEST_EXIT_CODE
+exit $TEST_EXIT_CODE