-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components): Updated the index of components #5233
chore(components): Updated the index of components #5233
Conversation
Thank you Alexey for the change! I have a few questions:
|
Yes. The update script is https://github.com/kubeflow/pipelines/blob/master/components/generate_component_index.py in the same directory. I can include information on launching it in the same README.
We try to encourage the users to use strict component versioning to increase reproducibility. Apart from deletion, which you've mentioned, another advantage is versioned. Some components are under active development. The component interfaces are sometimes changed. If someone links to the HEAD version, their pipeline may break any time. If the component works for the user, I'm not sure they have a big need to upgrade. |
Thank you for the reference, that is very helpful!
I think this is important enough for using versioned component link, so sounds good on using versioned link. Thank you for explaining! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.