Add metric and ui-metadata samples #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test kubeflow-pipeline-e2e-test |
qimingj
approved these changes
Dec 12, 2018
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
reviewed
Dec 17, 2018
| @@ -114,6 +114,32 @@ | |||
| "\n", | |||
| " (quotient, remainder) = divmod_helper(dividend, divisor)\n", | |||
| "\n", | |||
| " from tensorflow.python.lib.io import file_io\n", | |||
There was a problem hiding this comment.
Why do you need the tensorflow dependency?
Ark-kun
reviewed
Dec 17, 2018
| " 'numberValue': float(remainder),\n", | ||
| " }]}\n", | ||
| "\n", | ||
| " with file_io.FileIO(output_dir + 'mlpipeline-metrics.json', 'w') as f:\n", |
There was a problem hiding this comment.
Why not use the pythonic with open(...)?
Ark-kun
reviewed
Dec 17, 2018
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "#Advanced function\n", | ||
| "#Demonstrates imports, helper functions and multiple outputs\n", | ||
| "from typing import NamedTuple\n", | ||
| "def my_divmod(dividend: float, divisor:float) -> NamedTuple('MyDivmodOutput', [('quotient', float), ('remainder', float)]):\n", | ||
| "def my_divmod(dividend: float, divisor:float, output_dir:str = './') -> NamedTuple('MyDivmodOutput', [('quotient', float), ('remainder', float)]):\n", |
There was a problem hiding this comment.
This change goes against the idea that outputs should be outputs.
The metrics and metadata files should have just been added to the outputs list.
Ark-kun
reviewed
Dec 18, 2018
| @@ -79,6 +80,14 @@ def main(argv=None): | |||
| with file_io.FileIO('/mlpipeline-ui-metadata.json', 'w') as f: | |||
neuromage
pushed a commit
to neuromage/pipelines
that referenced
this pull request
Dec 22, 2018
* add metric sample code in roc component * Change mlpipeline artifacts output path to tmp folder * Revert /tmp path change and add output_dir in notebook sample * Revert /tmp path kubeflow#2
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* For bulk deployments support deploying a v0.6.2 version of Kubeflow in addition to v0.7 * For v0.6 kfctl apply won't succeed for an already deployed cluster so we need to check if the deployment already exists and if it does not redeploy
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This change is