Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the notebook TFX sample #517

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Improve the notebook TFX sample #517

merged 1 commit into from
Dec 12, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 11, 2018

  1. deployer model has name restrictions: cannot have '-' in the name
  2. surface potential errors in deployer because it could be permission issues, model name error etc
  3. update the tensorflow image with python3 because python_component_build uses python3 as the entrypoint

This change is Reviewable

…loyer, update the tensorflow image with python3
@gaoning777
Copy link
Contributor Author

/cc Ark-kun qimingj

@qimingj
Copy link
Contributor

qimingj commented Dec 12, 2018

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e14e765 into kubeflow:master Dec 12, 2018
@gaoning777 gaoning777 deleted the add-print-in-notebook branch December 19, 2018 17:21
neuromage pushed a commit to neuromage/pipelines that referenced this pull request Dec 22, 2018
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants