Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job to load sample #509

Merged
merged 5 commits into from
Dec 17, 2018
Merged

add job to load sample #509

merged 5 commits into from
Dec 17, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Dec 11, 2018

Add a job to load sample to pipeline backend once.
Reuse API server binary to load the samples since most code are shared.
The corresponding kubeflow code change is here kubeflow/kubeflow#2071

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Dec 11, 2018

/assign @Ark-kun

@IronPan IronPan changed the title [WIP] add job to load sample add job to load sample Dec 11, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 11, 2018

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Dec 14, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Dec 17, 2018

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 3306934 into kubeflow:master Dec 17, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update explainer demos with new notebooks

* Add updated explanation notebooks

* Update from review comments

* clean up

* rerun income explainer notebook to see output

* removing output as plot.ly graphs don't show on github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants