Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): Add TriggerPolicy to pipeline_spec #5080

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 2, 2021

Description of your changes:

Checklist:

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neuromage
Copy link
Contributor

/lgtm

api/v2alpha1/pipeline_spec.proto Outdated Show resolved Hide resolved
@chensun
Copy link
Member Author

chensun commented Feb 2, 2021

/hold

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 2, 2021
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@chensun
Copy link
Member Author

chensun commented Feb 2, 2021

/unhold

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot google-oss-robot merged commit 628e970 into kubeflow:master Feb 3, 2021
numerology pushed a commit to numerology/pipelines that referenced this pull request Feb 4, 2021
* Add TriggerPolicy to pipeline_spec

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants