Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): Fix the bug where pipeline_parameters is not used. #5002

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Jan 15, 2021

Description of your changes:
Fixes:

  • The Compiler().compile method accepts pipeline_parameters as an argument but doesn't actually use it.
  • The compiler CLI tool does not even expose an interface to accept pipeline parameters.

Checklist:

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@numerology numerology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chen! Overall LGTM

sdk/python/kfp/v2/compiler/main.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/compiler/main.py Outdated Show resolved Hide resolved
@numerology
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 0c600a2 into kubeflow:master Jan 19, 2021
@chensun chensun deleted the pipeline-parameters-bug branch January 20, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants