Add lightweight sample test #499
Conversation
|
/cc Ark-kun qimingj |
gaoning777
changed the title
| value: "{{inputs.parameters.test-results-gcs-dir}}" | ||
| - name: target-image-prefix | ||
| value: "{{inputs.parameters.target-image-prefix}}" | ||
| - name: dataflow-tft-image |
There was a problem hiding this comment.
Do you think there is a way we can simplify image replacement? Maybe the target-image-prefix has enough information?
There was a problem hiding this comment.
By pushing the image URL to the scripts, we unnecessarily create a consistency between the sample test yamll and sample test script because they need to agree on the image name. Right?
There was a problem hiding this comment.
I was thinking about the consistency between image names used by component builders (build_image.sh files), component definition (currently in sample python code), Cloud Build configs and test scripts/yamls. I think those image names must be consistent. The component builder and component definition should be the source of truth and the tests should not contain explicit image names/suffixes.
There was a problem hiding this comment.
By pushing the image URL to the scripts
What exactly do you mean by "scripts"? The component definitions in the pipeline python files? Or do you mean the test scripts?
There was a problem hiding this comment.
The sample tests should care about the image tags because we current run the sample tests as submit. I can see if we move them to postsubmit, it should work fine by using the image tags that are consistent with others , such as cloud build.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is