Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk.v2): Migrate to the new IR with subdag support #4981

Merged
merged 8 commits into from
Feb 3, 2021
Merged

chore(sdk.v2): Migrate to the new IR with subdag support #4981

merged 8 commits into from
Feb 3, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Jan 12, 2021 •
edited
Loading

Description of your changes:

Checklist:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
numerology
numerology reviewed Jan 13, 2021
View reviewed changes
Copy link

@numerology numerology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Chen

sdk/python/kfp/v2/compiler/compiler.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/dsl/component_spec.py Outdated Show resolved Hide resolved
numerology
numerology reviewed Jan 13, 2021
View reviewed changes
sdk/python/kfp/v2/dsl/container_spec.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/dsl/dsl_utils.py Outdated Show resolved Hide resolved
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun chensun changed the title [WIP][SDK.v2] Migrate to new IR chore(sdk.v2): Migrate to the new IR with subdag support Feb 1, 2021
@chensun chensun marked this pull request as ready for review February 1, 2021 11:03
@chensun
Copy link
Member Author

chensun commented Feb 1, 2021

/cc @kennethyang404

@k8s-ci-robot
Copy link
Contributor

@chensun: GitHub didn't allow me to request PR reviews from the following users: kennethyang404.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kennethyang404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@google-oss-robot
Copy link

@chensun: GitHub didn't allow me to request PR reviews from the following users: kennethyang404.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kennethyang404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neuromage
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 1, 2021
@chensun
Copy link
Member Author

chensun commented Feb 1, 2021

/hold

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@numerology
Copy link

/lgtm

Thanks!

@chensun
Copy link
Member Author

chensun commented Feb 3, 2021

/unhold

@google-oss-robot google-oss-robot merged commit 91c5a93 into kubeflow:master Feb 3, 2021
numerology pushed a commit to numerology/pipelines that referenced this pull request Feb 4, 2021
@chensun
chore(sdk.v2): Migrate to the new IR with subdag support (kubeflow#4981)
05592f3 
* migrate to new ir

* address review comments

* fix bugs

* fix pipeline parameters and tests

* fix components import

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuromage neuromage neuromage left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@numerology numerology Awaiting requested review from numerology

Assignees

@neuromage neuromage

@numerology numerology

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chensun @k8s-ci-robot @google-oss-robot @neuromage @numerology