-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): Update GCP component container to Python 3.7. Fixes #4959 #4960
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/lgtm |
components/gcp/container/component_sdk/python/kfp_component/google/dataflow/_client.py
Show resolved
Hide resolved
Thank you for tackling this, Chen. A general comment: It might be beneficial to split unrelated changes into separate PRs. It looks like this PR changes several things at once - Python 2, API regionalization and general refactoring. |
All changes are actually related. The
Also the backend now returns job URL in a different format, so we need to change the parsing logic. Though this is not a sdk/container related change, but it affects e2e runtime results which is currently broken. |
/test kubeflow-pipeline-frontend-test |
/lgtm Thanks @chensun ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Tested via Dataflow launch_python and launch_template sample notebooks.
Fixes #4959
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.