Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): Update GCP component container to Python 3.7. Fixes #4959 #4960

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Jan 6, 2021

Description of your changes:

  • Update GCP component container to using Python 3.7, also upgrade apache-beam[gcp] version.
  • Fix Dataflow client and sample.

Tested via Dataflow launch_python and launch_template sample notebooks.
Fixes #4959

Checklist:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@neuromage
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 6, 2021

Thank you for tackling this, Chen.

A general comment: It might be beneficial to split unrelated changes into separate PRs. It looks like this PR changes several things at once - Python 2, API regionalization and general refactoring.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 6, 2021
@chensun
Copy link
Member Author

chensun commented Jan 7, 2021

Thank you for tackling this, Chen.

A general comment: It might be beneficial to split unrelated changes into separate PRs. It looks like this PR changes several things at once - Python 2, API regionalization and general refactoring.

All changes are actually related. The apache-beam[gcp] version we pinned previously only works for Python 2.7. So as we upgrade to Python 3.7, we need to use a newer version of apache-beam[gcp]. And I found out that new SDK requires a few changes:

  • runner needs to be "DatatflowRunner" instead of just "dataflow"
  • region is now a required argument, otherwise we got compile time error: 'ValueError: Pipeline has validations errors: Missing required option: region.'

Also the backend now returns job URL in a different format, so we need to change the parsing logic. Though this is not a sdk/container related change, but it affects e2e runtime results which is currently broken.

@chensun
Copy link
Member Author

chensun commented Jan 7, 2021

/test kubeflow-pipeline-frontend-test

@numerology
Copy link

/lgtm
/approve

Thanks @chensun !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP component container is still based on Python 2.7
5 participants