Show all run outputs in dedicated tab #496
Conversation
|
/assign rileyjbauer |
|
/test kubeflow-pipeline-build-image |
| if (workflow && workflow.status && workflow.status.nodes) { | ||
| Object.keys(workflow.status.nodes).forEach(n => | ||
| outputPaths = outputPaths.concat(this.loadNodeOutputPaths(workflow.status.nodes[n]))); | ||
| this.loadNodeOutputPaths(workflow.status.nodes[n]).map(path => |
There was a problem hiding this comment.
I can't wait for a better way to iterate over values in a map like this 😷
There was a problem hiding this comment.
I don't think we want an easier way. I found that lodash has map and iteratee methods that can be used here, but they don't actually look more readable.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label area/front-end |
* wip, showing outputs with no labels * showing outputs with step labels * wip fixing tests * fix tests * test new functionality * global tree * add empty message * pr comments
* Other workflows are using test_py_lint and making it a pytest breaks them. * Create a new version py_lint_test.py for people that want to migrate.
Fixes #331.
Fixes #92.
This change is