Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): update requirements.txt #4928

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

chensun
Copy link
Member

@chensun chensun commented Dec 21, 2020

Description of your changes:

  • Bump kfp-server-api version to 1.1.2 in requirements.in (matching what's specified in setup.py)
  • Re-generate requirements.txt

Checklist:

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Dec 21, 2020

I was looking at some weird presubmit error that I couldn't repo locally (#4891 (comment)), and noticed that CI installs kfp-server-api==1.0.0 which doesn't comply with the version required in setup.py

# Note, please also update ./requirements.in
'kfp-server-api>=1.1.2, <2.0.0',

@Bobgy
Copy link
Contributor

Bobgy commented Dec 22, 2020

/LGTM
/Hold
Not sure if you are ready to merge, leave the decision to you

@chensun
Copy link
Member Author

chensun commented Dec 22, 2020

/LGTM
/Hold
Not sure if you are ready to merge, leave the decision to you

Thanks!
Yes, this one's ready to merge.

/unhold

@k8s-ci-robot k8s-ci-robot merged commit cd6580c into kubeflow:master Dec 22, 2020
@chensun chensun deleted the pip-dep branch December 22, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants