Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): update release doc with caveats on release-on-tag retry #4917

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Dec 18, 2020

To be verified by the next release manager.

/hold

@Bobgy
Copy link
Contributor

Bobgy commented Dec 21, 2020

OK, makes sense to me.
I never noticed we can click the rerun button on github UI, that could indeed be broken.

@Bobgy
Copy link
Contributor

Bobgy commented Dec 21, 2020

/lgtm
/approve
It seems to me this is good enough to merge.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Feb 1, 2021

I verified again with release 1.4.0-rc.1, the issue described in this PR is the case, so we should avoid using "re-run" from the GitHub Actions page.

Merging this PR.
/unhold

@google-oss-robot google-oss-robot merged commit f00dad8 into kubeflow:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants