Commits on Mar 12, 2021

1. feat(sdk): Enable setting OwnerReference on ResourceOps. Fixes kubefl… …

   …ow#1779
   
   Argo supports a field in the ResourceTemplate that makes the controller
   add an owner reference of the workflow to the created resource since
   v2.4.0 [1].
   With the upgrade of Argo client [2] and deployment [3] we are now able
   to exploit it.
   
   We set it to 'false' by default on all ResourceOps (actually, leave it
   empty).
   
   Setting the field to 'true' for VolumeOps allows the garbage collection
   of PVCs upon workflow cleanup [4].
   
   [1] https://github.com/argoproj/argo/blob/v2.4.0/pkg/apis/workflow/v1alpha1/workflow_types.go#L1044-L1045
   [2] kubeflow#4498
   [3] kubeflow#3537
   [4] kubeflow#1779
   
   Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>

   

   elikatsis committed Mar 12, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 9ba27af
   • Browse repository at this point

   Copy the full SHA

   9ba27af View commit details

   Browse the repository at this point in the history