Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh while waiting for run to start #472

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 5, 2018

Fixes #464.


This change is Reviewable

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 5, 2018

/test presubmit-e2e-test

2 similar comments
@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 5, 2018

/test presubmit-e2e-test

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 5, 2018

/test presubmit-e2e-test

@yebrahim yebrahim changed the title [WIP] Refresh while waiting for run to start Refresh while waiting for run to start Dec 5, 2018
@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 5, 2018

Ready for review. I've rerun the test three times and it passed in all of them, so hopefully this fixes the flakiness.

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 5, 2018

/lgtm

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 5, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim yebrahim merged commit 5c9010c into kubeflow:master Dec 5, 2018
@yebrahim yebrahim deleted the flakey-fix branch December 5, 2018 03:14
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Inference Logger Types

* Update from review

* Update from review

* Fix typo in InferenceLogResponse

* review updates

* Change enum Both to All

* revert url to pointer

* Simply to just logger

* Add missing CRD file
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…low#472)

* Add delivery pipeline scripts for tekton-catalog images

* Combine build binaries tasks and scripts into generic

* Delete secret during cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants