Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for the run comparison page #469

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Dec 4, 2018

Fixes #382

CollapseButton is converted to a class so that its react components can be referenced rather than being anonymous.


This change is Reviewable

@rileyjbauer
Copy link
Contributor Author

/test presubmit-e2e-test

frontend/src/pages/Compare.tsx Show resolved Hide resolved
frontend/src/pages/Compare.test.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Compare.test.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Compare.test.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Compare.test.tsx Show resolved Hide resolved
frontend/src/pages/Compare.test.tsx Show resolved Hide resolved
frontend/src/pages/Compare.test.tsx Show resolved Hide resolved
Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4c5e629 into master Dec 5, 2018
@IronPan IronPan deleted the compare-page-tests branch June 28, 2019 18:48
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* KFP 1.4.0 Rebase

Resolves kubeflow#469

* Remove duplicated KFP samples

* Resolve api and backend and SDK test conflicts

* Upgrade kfp requirements to 1.4.0

* Update testdata regenerate YAML files

* Resolve CONTRIBUTING.md

* Regenerate KFP samples compile report

* Update README.md files for KFP version 1.4.0

* Resolve frontend conflicts

* Revert list-wrapped loop arguments

* Remove compiler_tests.py.rej
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants