fix(backend): Caching - Make the cache key depend on output names and paths #4675
Conversation
Output artifact/parameter names and paths are important and need to be considered.
|
This change is |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@Ark-kun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
chensun
force-pushed
the
master
branch
2 times, most recently
from
7542f0e
to
44d22a6
Compare
Ark-kun
removed
the
lifecycle/stale
|
Without this fix, the results reused from cache can be incorrect when the task is exactly the same, but uses different output names. |
|
/cc @Bobgy @chensun @zijianjoy |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Output artifact/parameter names and paths are important and need to be considered.