Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import bug #463

Merged
merged 1 commit into from
Dec 4, 2018
Merged

import bug #463

merged 1 commit into from
Dec 4, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 4, 2018

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 4, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 4, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 632370c into master Dec 4, 2018
@gaoning777 gaoning777 deleted the ngao/import-bug branch February 8, 2019 18:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…date kf_unittests to create a valid workflow (kubeflow#463)

* kf_unittests should create a suitable argo workflow for the unittests

* Create a simple CLI tool e2e_tool.py to support working with py_funcs
  for E2E tests

* run_e2e_workflow.py should pass the name and namespace to the py_func.

* Add to util.load_kube_config an option to skip printing out the kube
  config.

* Remove ksonnet E2E tests.

Related to kubeflow/kubeflow#3035 migrate e2e tests off ksonnet

* Refactor to reduce boilerplate.

* Add a utility function to generate the repository; update the README.

* More cleanup.

* Wait for status.

* Run_e2e_workflow.py needs to adjust the python path so py_funcs are on the path.

* Fix typo.

* * Add a dry-run command
* Fix a bug in the add task command.

* * Add utility for getting the link to the stackdriver logs
* Attach stacdriver logs for each step to its annotations.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Updating a few SDK files remaining after kubeflow#463

Related kubeflow#463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants