Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait until logs appear right in e2e test #459

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Wait until logs appear right in e2e test #459

merged 1 commit into from
Dec 4, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 4, 2018 •
edited
Loading

Fixes #453.

The issue was that sometimes logs are grabbed too early, when they haven't been downloaded from the pod yet. This results in logs being just "1", which is the text of the line numbers gutter, which only has one line.

This change is Reviewable

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim yebrahim mentioned this pull request Dec 4, 2018
Closed
@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

5 similar comments
@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim yebrahim changed the title [WIP] Wait until logs appear right in e2e test Wait until logs appear right in e2e test Dec 4, 2018
@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

2 similar comments
@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

rileyjbauer
rileyjbauer reviewed Dec 4, 2018
View reviewed changes
Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer, yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer, yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 4, 2018

/test presubmit-e2e-test

@yebrahim yebrahim merged commit 401f738 into master Dec 4, 2018
@yebrahim yebrahim deleted the yebrahim/patch-1 branch December 4, 2018 23:40
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@jinchihe @k8s-ci-robot
fix one e2e test problem (kubeflow#459)
8fa0ca6
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@yhwang
test: Add pipeline yaml for tekton pipeline (kubeflow#459)
895d5b9 
In order to run tekton pipeline on IKS, need to define
listener, pipeline and task YAMLs. Inside the pipeline YAML,
it defines a series of tasks to git clone, run unittest, build images,
deploy tekton, deploy kfp-tekton, run e2e test and undeploy.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjbauer rileyjbauer rileyjbauer left review comments

Assignees

@rileyjbauer rileyjbauer

Labels
approved area/frontend lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yebrahim @k8s-ci-robot @rileyjbauer